Add PIC32MZ emulator tests#10495
Merged
Merged
Conversation
Adds PIC32MZ EC / EF emulators with hardware acceleration. Also fix a stack pointer free bug in the PIC32 hardware acceleration code.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds automated CI coverage for the PIC32MZ simulators (EC/EF variants, direct-register and Harmony 3 ports) and fixes a PIC32MZ hardware-acceleration cleanup issue where a non-heap hash buffer could be freed.
Changes:
- Fix PIC32MZ hash cache cleanup to avoid freeing the standard/embedded hash buffer (stack/struct-backed) in
wc_Pic32HashFree. - Add a new GitHub Actions workflow to build the PIC32MZ simulator Docker images and run the wolfCrypt test suite across EC/EF and direct/harmony configurations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
wolfcrypt/src/port/pic32/pic32mz-crypt.c |
Adjusts hash-cache free logic to prevent freeing non-heap buffers by comparing against the per-hash standard buffer pointer. |
.github/workflows/pic32mz-sim.yml |
Introduces a CI workflow to run wolfCrypt tests under the PIC32MZ simulators using Docker images from wolfSSL/simulators. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
JacobBarthelmeh
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PIC32MZ EC / EF emulators with hardware acceleration. Also fix a stack pointer free bug in the PIC32 hardware acceleration code.